feat: default to fed2 when @link is present #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
StephenBarlow and
lrlna
as code owners
✅ Deploy Preview for apollo-cli-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
EverlastingBugstopper
force-pushed
the
avery/auto-fed-version
branch
from
345d0fd
to
86594b4
Compare
StephenBarlow
approved these changes
Apr 21, 2022
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
EverlastingBugstopper
force-pushed
the
avery/auto-fed-version
branch
from
1f94070
to
1f5ce70
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1090
need to merge
avery/make-fed-version-optionaland releaseapollo-federation-types@v0.5.0before merging this.only change is that if you do not specify
federation_version: 2and you have an@linkdirective in a single subgraph, we'll default to Federation 2 rather than the old default of Federation 1.