Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old CLI docs to Rover docset #1568

Merged
merged 2 commits into from Apr 10, 2023
Merged

Conversation

StephenBarlow
Copy link
Contributor

No description provided.

@@ -0,0 +1,81 @@
---
title: The Apollo CLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc currently lives in the "root" docset, and it's marginally less vestigial in the Rover docs than it is in its current home.

@@ -10,20 +16,21 @@
"Conventions": "/conventions",
"Privacy and data collection": "/privacy",
"Contributing": "/contributing",
"Migrating from the Apollo CLI": "/migration",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this one down to the bottom

@@ -10,20 +16,21 @@
"Conventions": "/conventions",
"Privacy and data collection": "/privacy",
"Contributing": "/contributing",
"Migrating from the Apollo CLI": "/migration",
"Error codes": "/errors",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popping this one up because it's in a category-of-one

@StephenBarlow StephenBarlow changed the title Move old CLI docs and do a nomenclature docs pass Move old CLI docs to Rover docset Apr 10, 2023
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pulling this out into its own PR - this is great πŸ‘πŸΌ

@EverlastingBugstopper EverlastingBugstopper added the docs πŸ“ improvements or additions to docs on the docs site label Apr 10, 2023
@EverlastingBugstopper EverlastingBugstopper merged commit 4e821cd into main Apr 10, 2023
1 of 8 checks passed
@EverlastingBugstopper EverlastingBugstopper deleted the sb/move-apollo-cli-docs branch April 10, 2023 19:17
@EverlastingBugstopper EverlastingBugstopper added this to the vNext milestone Apr 10, 2023
EverlastingBugstopper added a commit that referenced this pull request Apr 19, 2023
# [0.14.0] - 2023-04-19

> Important: 1 potentially breaking changes below, indicated by **❗
BREAKING ❗**

## ❗ BREAKING ❗

- **`rover config whoami` outputs to `stdout` instead of `stderr` and
using `--format json` includes more information than success or failure
- @scombat, #1560 fixes #1380**

When running `rover config whoami`, the output will print to `stdout`
instead of `stderr`. This may break scripts that relied on parsing the
output from `stderr`. The good news is that these scripts should be
easier to write because passing `--format json` to `rover config whoami`
will print structured output that can be parsed with a tool like
[`jq`](https://stedolan.github.io/jq/tutorial/).

## πŸš€ Features

- **ALlow custom headers when running introspection with `rover
supergraph compose` - @dbanty, #1574 fixes #615**

A new field is available in `supergraph.yaml` files that allows sending
headers along with introspection. This value also supports environment
variable interpolation for sensitive values like authentication tokens.

- **Print a wanring when attempting to publish a subgraph with an
invalid routing URL - @trevor-scheer, #1543 fixes #1477**

When running `rover subgraph publish`, if the `--routing-url` you
specify or the routing URL stored in GraphOS is unroutable, a warning
will be printed. If you are not in CI, you will need to manually confirm
the publish to continue. You can dismiss the warning by passing
`--allow-invalid-routing-url`.

  **Note:** This warning will become a hard error in the future.

## πŸ› Fixes

- **Spawn a thread to avoid a rare deadlock in `rover dev` -
@EverlastingBugstopper, #1548 fixes #1544**

## πŸ›  Maintenance

- **Updates dependencies - @EverlastingBugstopper, #1562**

  `apollo-parser` 0.4 -> 0.5
  `git2` 0.16 -> 0.17
  `opener` 0.5 -> 0.6
  `predicates` 2 -> 3
  `serial_test` 1 -> 2
  `toml` 0.5 -> 0.7
  ~`crossterm`~

- **Use Apple Silicon in CI - @EverlastingBugstopper, #1557 fixes
#1555**

There should be no user facing change here, we just run builds in CI
much faster.

## πŸ“š Documentation

- **Adds Apollo CLI migration guide to Rover docs - @StephenBarlow,
#1568**

The (deprecated) Apollo CLI documentation and the migration guide for
Rover now live in Rover's docset.

- **Cleans up nomenclature and links in Rover docs - @StephenBarlow,
#1571 and #1573**

Rover's documentation has been updated to refer to the [new GraphOS
documentation](https://www.apollographql.com/docs/graphos) along with
updating some terminology.

- **Mention community-maintained installation methods - @dbanty, #1542**

Rover's documentation now mentions the unofficial installation methods
`nix` and `brew`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs πŸ“ improvements or additions to docs on the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants