Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide from the Apollo CLI -> Rover #425

Merged
merged 18 commits into from Apr 13, 2021
Merged

Conversation

JakeDawkins
Copy link
Contributor

Resolves #284

@JakeDawkins JakeDawkins added the docs 📝 improvements or additions to docs on the docs site label Apr 7, 2021
@@ -1,14 +1,18 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied these changes directly from apollo-server

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great @JakeDawkins - thanks a bunch for putting this together

docs/source/migration.md Outdated Show resolved Hide resolved

## Configuring

Rover's approach to [configuration](./configuring) is much more granular and less abstracted than the Apollo CLI. Most configuration options in Rover are configured as flags on a command, rather than items in a config file. The only config files that Rover uses are hidden config files created by the `config auth` command and another as input to [`supergraph compose`](./supergraphs#configuration).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's worth noting what the old config format looks like/the info it contains and then map each of those values to how you'd configure it in rover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see what I can do for that. I had the same thought, but there's a bunch of edge cases with the old config. I think I can figure something out though 😄

docs/source/migration.md Outdated Show resolved Hide resolved
docs/source/migration.md Show resolved Hide resolved
@@ -17,17 +17,13 @@ module.exports = {
'getting-started',
'configuring',
'ci-cd',
'essentials',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider adding a redirect to conventions from essentials?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could, but I don't think it's stricly necessary. If we were in GA, I'd say probably

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh looks like this was necessary! I'll add momentarily

@JakeDawkins JakeDawkins merged commit ff44f4a into main Apr 13, 2021
@JakeDawkins JakeDawkins deleted the jake/migration branch April 13, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📝 improvements or additions to docs on the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration guide from apollo to Rover
3 participants