Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cargo xtask #562

Merged
merged 20 commits into from Jun 11, 2021
Merged

feat: cargo xtask #562

merged 20 commits into from Jun 11, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented May 21, 2021

Fixes #388

  • Prep
    • Update npm dependencies
    • Install npm dependencies
    • Update npm package version
    • Run npm publish --dry-run
    • Update shell installer versions
    • Update error reference material
    • Copy the root CONTRIBUTING.md to docs/source/contributing.md
  • Dist
    • Build release binary
    • Use strip to make binary size smaller
  • Test
    • Make sure to accept a --target argument
    • Run cargo test --workspace --locked --target {target}
    • Run cargo test --workspace --locked --no-default-features --target {target}
    • Run cargo fmt --all -- --check
    • Run cargo clippy --all -- -D warnings and cargo clippy --all --no-default-features -- -D warnings
  • Replace code in GitHub Actions with xtask
  • Fix bug with auto-computing SHAs - programatically ensure they are computed or fail the release
  • Update release docs to run cargo xtask prep
  • Include info on using cargo xtask in CONTRIBUTING.md

Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good @EverlastingBugstopper !! Super happy with how this turned out.

crates/xtask/Cargo.toml Outdated Show resolved Hide resolved
crates/xtask/src/commands/cargo/runner.rs Outdated Show resolved Hide resolved
crates/xtask/src/commands/prep/installers.rs Outdated Show resolved Hide resolved
crates/xtask/src/utils.rs Outdated Show resolved Hide resolved
RELEASE_CHECKLIST.md Show resolved Hide resolved
@EverlastingBugstopper
Copy link
Contributor Author

the changes to the CI process have been tested on my fork 😄 this is good to go

@EverlastingBugstopper EverlastingBugstopper added this to the June 22 milestone Jun 10, 2021
@lrlna
Copy link
Member

lrlna commented Jun 11, 2021

This looks good! I'll let you do the honours of pressing the merge button :)

@EverlastingBugstopper EverlastingBugstopper merged commit 49dd8e4 into main Jun 11, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/xtask branch June 11, 2021 16:29
This was referenced Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cargo-xtask for automating builds
2 participants