This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
feat(NA): force close without try reconnect #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
changed the title
Merged
|
👍 |
Closed
baconz
pushed a commit
to PhiloInc/subscriptions-transport-ws
that referenced
this pull request
Apr 24, 2018
* add debug option to runQuery * add test for integrations * update changelog * fix lint error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys ( @Urigo @DxCx @helfer @dotansimha @NeoPhi ) this pull request is a fix for the following situation:
1- Client connects to the server with
reconnect=trueto prevent for example temporary network failures.2- Due to a necessary situation, for example a logout, the user of this package wants to close the client.
3- In this situation, even with
reconnect=true, thetryReconnectmethod shouldn't be called.