Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

docs(README): Fix example for subscribe and subscribeToMore methods #273

Merged
merged 2 commits into from Sep 15, 2017

Conversation

Tobino
Copy link
Contributor

@Tobino Tobino commented Sep 14, 2017

Add 2 examples for both subscribe and subscribeToMore.

subscribeToMore is not a function on apolloClient but working on a query result. Fix #265
subscribe need a subscriber for a full working example.

Both example were test with hybrid and Full WebSocket Transport.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@mistic
Copy link
Contributor

mistic commented Sep 15, 2017

The api on the examples won't work with apollo-client 2.X version, however I think we can still merge it for the time being.

@NeoPhi @DxCx @dotansimha @Urigo can u give your thoughts here please?

@NeoPhi NeoPhi merged commit bffe05d into apollographql:master Sep 15, 2017
baconz pushed a commit to PhiloInc/subscriptions-transport-ws that referenced this pull request Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants