This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Emit event when an websocket error occurs. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damour: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
damour
force-pushed
the
feature/websocket_error_event
branch
2 times, most recently
from
519b3fb
to
6b505b2
Compare
|
Will this allow logging the errors with something like apollo-link-error? |
|
@tim-soft yes I guess so! Can this PR please taken care of? This is pretty important as right now there is no possibility to catch Websocket errors using the |
mxstbr
suggested changes
Mar 22, 2018
README.md
Outdated
| @@ -255,7 +255,7 @@ ReactDOM.render( | |||
| #### `unsubscribeAll() => void` - unsubscribes from all active subscriptions. | |||
|
|
|||
| #### `on(eventName, callback, thisContext) => Function` | |||
| - `eventName: string`: the name of the event, available events are: `connecting`, `connected`, `reconnecting`, `reconnected` and `disconnected` | |||
| - `eventName: string`: the name of the event, available events are: `connecting`, `connected`, `reconnecting`, `reconnected`, `disconnected` and `websocket_error` | |||
There was a problem hiding this comment.
Let's call this event error instead, no need to specify websocket just like in the other events.
README.md
Outdated
| @@ -285,6 +285,11 @@ ReactDOM.render( | |||
| - `thisContext: any`: `this` context to use when calling the callback function. | |||
| - => Returns an `off` method to cancel the event subscription. | |||
|
|
|||
| #### `onWebSocketError(callback, thisContext) => Function` - shorthand for `.on('websocket_error', ...)` | |||
There was a problem hiding this comment.
Same here, no need for the WebSocket, let's call this onError.
damour
force-pushed
the
feature/websocket_error_event
branch
from
6b505b2
to
1a3d0e6
Compare
damour
force-pushed
the
feature/websocket_error_event
branch
from
1a3d0e6
to
c46c5d8
Compare
baconz
pushed a commit
to PhiloInc/subscriptions-transport-ws
that referenced
this pull request
Apr 24, 2018
…types/sinon-2.1.0 Update @types/sinon to the latest version 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
Writing simple (load)testing tools. At that moment there is no simple way to determinate connection errors. Also useful to debug network troubles.
Could this be a plugin?
No, we can't subscribe to ws error event directly.
Is there a workaround?
Save connection state(to check that connection closed by server) and catch
disconnectedevent. But we don't have any error details.