This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Allow data and errors in payload of SUBSCRIPTION_DATA #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoPhi
reviewed
Mar 2, 2017
CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ### vNEXT | |||
|
|
|||
| ### 0.5.4 | |||
There was a problem hiding this comment.
These should just be placed under vNEXT as multiple different merge requests may get bundled into the next release.
NeoPhi
reviewed
Mar 2, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "subscriptions-transport-ws", | |||
| "version": "0.5.3", | |||
| "version": "0.5.4", | |||
There was a problem hiding this comment.
No need to change this in the MR.
NeoPhi
reviewed
Mar 2, 2017
src/client.ts
Outdated
| @@ -306,7 +306,8 @@ export class SubscriptionClient { | |||
| if (parsedMessage.payload.data && !parsedMessage.payload.errors) { | |||
There was a problem hiding this comment.
Probably cleaner to conditionally set playloadData and playloadErrors and have only a single call to this.subscriptions[subId].handler.
|
Thanks for the feedback, good points, just updated the MR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, at Graphcool, we have the use case, that sometimes we want to send
dataANDerrorson thepayloadofSUBSCRIPTION_DATAat the same time.This is especially needed for our permissions system, where it could be that the requesting client is only allowed to see some fields on a query. In that case we don't want to disable all other fields, so we send the allowed fields and an error that explains why some fields are null.
This PR just makes sure, that if there is the
errorsproperty,datais not just nulled, but is actually checked if there is data.