Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add svelte sfc support #17

Merged
merged 3 commits into from Sep 7, 2021
Merged

feat: add svelte sfc support #17

merged 3 commits into from Sep 7, 2021

Conversation

alexanderniebuhr
Copy link
Contributor

@alexanderniebuhr alexanderniebuhr commented Sep 1, 2021 •
edited by sync-by-unito bot

this pr allows syntax highlighting for svelte files, which are similar in structure than vue files.

┆Issue is synchronized with this Jira Task by Unito

@jgzuke jgzuke self-requested a review September 7, 2021 07:15
jgzuke
jgzuke reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@jgzuke jgzuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small change

src/language-server/document.ts Outdated Show resolved Hide resolved
jgzuke
jgzuke approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@jgzuke jgzuke left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, messed up the spacing! Thanks for adding this 😄

src/language-server/document.ts Outdated Show resolved Hide resolved
@jgzuke jgzuke merged commit 45605f0 into apollographql:main Sep 7, 2021
@sync-by-unito sync-by-unito bot assigned jgzuke and unassigned jgzuke Sep 7, 2021
@apollographql apollographql deleted a comment from sync-by-unito bot Sep 7, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Apr 14, 2022
Closed
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgzuke jgzuke jgzuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexanderniebuhr @jgzuke