Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraphiQL version to 0.9.1 #293

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Conversation

ephemer
Copy link
Contributor

@ephemer ephemer commented Jan 31, 2017

I have just spent a couple of hours trying to get deprecation directives (among other things) working in graphql-server. The last of these issues had me wondering why graphql/graphiql#273 was closed but seemingly not working/implemented, even after upgrading to the latest package versions of graphql-server, graphiql, graphql-tools etc.

The issue is that the locally installed GraphQL implementation is not used at all and graphql-server seems to do its own dependency management instead.

Is it possible to just import 'graphiql'? and add graphiql as a peer dependency to graphql-server? What edge cases was the current implementation intending to fix?

In the meantime, is it reasonable to just upgrade the GraphiQL version like this? There appear to have been efforts to make GraphiQL versions backwards compatible, but I'm far from an expert on it.

@DxCx
Copy link
Contributor

DxCx commented Jan 31, 2017

Thanks @ephemer, upgrade looks good, that's how it's done.
regarding importing directly, i don't understand what you are trying to achieve.
please open a separate issue and let's discuss.. :)

@DxCx DxCx merged commit af2245c into apollographql:master Jan 31, 2017
@ephemer ephemer deleted the patch-1 branch January 31, 2017 16:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants