Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Pass component display name to watchQuery metadata. #363

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Pass component display name to watchQuery metadata. #363

merged 1 commit into from
Dec 9, 2016

Conversation

glasser
Copy link
Member

@glasser glasser commented Dec 8, 2016 •
edited
Loading

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes) — discussed in person
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Metadata is a new feature added in apollo-client@0.5.13

@glasser glasser requested a review from stubailo December 8, 2016 00:39
@zol zol added the in progress label Dec 8, 2016
@jbaxleyiii
Copy link
Contributor

@glasser will this require a certain version of AC?

@glasser
Copy link
Member Author

glasser commented Dec 9, 2016

Yes (0.5.13), but I think it's fine to not strictly require that version in the peer deps since it'll just get ignored otherwise.

@glasser
Pass component display name to watchQuery metadata.
39fe372 
Metadata is a new feature added in apollo-client@0.5.13. It's OK to pass
the option in to older clients; it will just be ignored.

This will be used by Apollo Chrome DevTools!
jbaxleyiii
jbaxleyiii approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@jbaxleyiii jbaxleyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jbaxleyiii jbaxleyiii merged commit 02fe991 into master Dec 9, 2016
@jbaxleyiii jbaxleyiii deleted the glasser/watch-metadata branch December 9, 2016 01:10
@zol zol removed the in progress label Dec 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbaxleyiii jbaxleyiii jbaxleyiii approved these changes

@stubailo stubailo Awaiting requested review from stubailo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glasser @jbaxleyiii @zol