Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React example presets have some bad css/sass #184

Closed
apolopena opened this issue Jan 26, 2022 · 3 comments
Closed

React example presets have some bad css/sass #184

apolopena opened this issue Jan 26, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@apolopena
Copy link
Owner

apolopena commented Jan 26, 2022

Describe the bug

Styling problems have appeared for the example projects that use bootstrap css.

  • The Q&A header does not center
  • The answers badge is hard to read and the numbers on it dont show up

This is a regression possibly due to hotfix 140

Screenshots

image

Steps to reproduce

https://gitpod.io/#EXAMPLE=1/https://github.com/apolopena/gitpod-laravel-starter/tree/development

Expected behavior

  • Q&A header should be centered on any screen width
  • Answers badge should be more readable the the number of answers a questio has should appear here

Additional information

The sass version should really no longer be pinned to an old version which is what had to be done for hotfix 140

Perhaps removing hotfix140 from the example projects that use bootstrap will automagically solve the problem.

@apolopena apolopena added the bug Something isn't working label Jan 26, 2022
@apolopena apolopena added this to the Backlog 🗂 milestone Jan 26, 2022
@apolopena apolopena self-assigned this Jan 26, 2022
@apolopena apolopena changed the title React example presets have some bad css/saas React example presets have some bad css/sass Jan 26, 2022
@apolopena
Copy link
Owner Author

Its not hotfix 140, however this will be removed as it is no longer needed.

@apolopena
Copy link
Owner Author

It appears that this is a bootstrap 5 vs boostrap 4 issue.

Laravel updates its version of bootstrap when it makes minor version changes and since gitpod-laravel-starter uses Laravel 8.* the version that example projects use will get their bootstrap (and other packages) package version bumped up.

@apolopena
Copy link
Owner Author

Will attempt to fix this with #185 and may also involve #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant