Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React example presets may not work properly with Laravel version < 8 #186

Closed
apolopena opened this issue Jan 26, 2022 · 1 comment
Closed

React example presets may not work properly with Laravel version < 8 #186

apolopena opened this issue Jan 26, 2022 · 1 comment
Assignees
@apolopena
Labels
bug Something isn't working
Milestone
Backlog 🗂

Comments

@apolopena
Copy link
Owner

Describe the bug

Example presets such as the react examples were built on laravel 8.*
Currently the React example preset repositories do not use their own package.json so many dev dependencies will be bumped down when using an older version of Laravel.

This has not been tested yet but I came across it while attempting to fix #185

Screenshots

Steps to reproduce

TBD

Expected behavior

React preset examples should work regardless of Laravel version however this may not be possible so TBD

Additional information

The only decent quick fix might be to log a warning about a version mismatch if the Laravel major version does not match the version the preset example was built with.
@apolopena apolopena added the bug Something isn't working label Jan 26, 2022
@apolopena apolopena self-assigned this Jan 26, 2022
@apolopena apolopena mentioned this issue Jan 26, 2022
Closed
apolopena added a commit to apolopena/qna-typescript-demo-skeleton that referenced this issue Jan 27, 2022
@apolopena
Pin package.json
b6c3f5b 
Fixes: apolopena/gitpod-laravel-starter#186
Pin package major versions so this project wil not break unexpectedly if/when Laravels minor version increases.
@apolopena apolopena added this to the Backlog 🗂 milestone Jan 27, 2022
@apolopena apolopena reopened this Jan 27, 2022
@apolopena
Copy link
Owner Author

I already had a fix in place for this, just didn't realize it:

apolopena added a commit to apolopena/qna-typescript-demo-skeleton that referenced this issue Jan 27, 2022
@apolopena
Release 1.1.1 (#3)
ef41c9f 
* Pin package.json

Fix: apolopena/gitpod-laravel-starter#186
Pin package major versions so this project wil not break unexpectedly if/when Laravels minor version increases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog 🗂
Development

No branches or pull requests
1 participant
@apolopena