Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shellscript linter throws SC1091's #193

Closed
apolopena opened this issue Jan 29, 2022 · 1 comment
Closed

Shellscript linter throws SC1091's #193

apolopena opened this issue Jan 29, 2022 · 1 comment
Assignees
@apolopena
Labels
passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements very minor A bug that is almost not a bug because it is so ingsignificat
Milestone
v1.5 release 🚀

Comments

@apolopena
Copy link
Owner

apolopena commented Jan 29, 2022 •
edited

  1. Create a new workspace
  2. Run: lint-starter

SC1091 appears for several different files.

image

The fix will be to add:

# shellcheck disable=SC1091

to the header of those files.
@apolopena apolopena added task tasks not related to bugs or enhancements very minor A bug that is almost not a bug because it is so ingsignificat labels Jan 29, 2022
@apolopena apolopena self-assigned this Jan 29, 2022
@apolopena apolopena added this to the Next Release 🔮 milestone Feb 3, 2022
@apolopena
Copy link
Owner Author

Confirmed that this only occurs in Gitpod but not locally

apolopena added a commit that referenced this issue Feb 3, 2022
@apolopena
🐛 FIX: #193
81bad09
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Feb 3, 2022
@apolopena apolopena mentioned this issue Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements very minor A bug that is almost not a bug because it is so ingsignificat
Projects
None yet
Milestone
v1.5 release 🚀
Development

No branches or pull requests
1 participant
@apolopena