Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lint-scripts.sh to be run locally #195

Closed
apolopena opened this issue Feb 2, 2022 · 0 comments
Closed

Allow lint-scripts.sh to be run locally #195

apolopena opened this issue Feb 2, 2022 · 0 comments
Assignees
Labels
passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements

Comments

@apolopena
Copy link
Owner

Currently it is not possible lint-starter on a local machine outside the gitpod platform.
Linting the scripts is an important step when developing gitpod-laravel-starter outside of Gitpod.

Change:

path() {
  echo "$GITPOD_REPO_ROOT/.gp"
}

To

path() {
  [[ -z $GITPOD_REPO_ROOT ]] && GITPOD_REPO_ROOT="$(pwd)"
  echo "$GITPOD_REPO_ROOT/.gp"
}
@apolopena apolopena added the task tasks not related to bugs or enhancements label Feb 2, 2022
@apolopena apolopena self-assigned this Feb 2, 2022
@apolopena apolopena modified the milestone: v1.4 release 🚀 Feb 2, 2022
@apolopena apolopena added the in-development Bug or feature is currently being worked on label Feb 3, 2022
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-development Bug or feature is currently being worked on labels Feb 3, 2022
@apolopena apolopena added this to the Next Release 🔮 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements
Projects
None yet
Development

No branches or pull requests

1 participant