Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: better lint support #58

Closed
lavrton opened this issue May 30, 2013 · 9 comments
Closed

Feature request: better lint support #58

lavrton opened this issue May 30, 2013 · 9 comments

Comments

@lavrton
Copy link
Contributor

lavrton commented May 30, 2013

What do you think about add better lint support?
Tools:

  • coffee -l
  • coffeelint

Also I think it is possible to add jshint support (with back to coffee report).

@aponxi
Copy link
Collaborator

aponxi commented May 30, 2013

You mean the checksyntax command here, right?

I would need to check the difference between coffee -l and coffeelint and see which one would be better. Then compare it to the current method... Bit of a research to be done on my part. I'll get on with it when I'm on my own computer.

Certainly it would be something nice to add! I have to ask though, is there a particular reason why you are requesting this? I mean what are the pro's and cons to the current state and coffeelint or coffee -l?

I'm asking this to improve the quality of the solution based on your needs.

@lavrton
Copy link
Contributor Author

lavrton commented May 30, 2013

For ST2 alredy exists plugin https://github.com/SublimeLinter/SublimeLinter, this one works with coffee via coffee -l.

As I know coffee -l only check is syntax ok or not. Nothing else! With http://www.coffeelint.org/ you can lint your code with some "code conversation". For example class name MUST be in camel case.

Also there are https://github.com/dotCypress/CoffeeLint. But doesn't work for me.

Here will be awesome to highlight line where you have lint error, not only message.

I can't find lint tool that can check undefined or unused variables. Idea - use jshint.

@aponxi
Copy link
Collaborator

aponxi commented May 31, 2013

Is it okay if it displays the output of linting in that output panel I made for run script? The one you get with alt shift R or was it ctrl shift R

@lavrton
Copy link
Contributor Author

lavrton commented Jun 1, 2013

It is ok. But of course it is better to highlight line with error.

@aponxi
Copy link
Collaborator

aponxi commented Jun 1, 2013

Do you know how to highlight ? Or do you mean select the line that has error? Do you want it to be displayed like the command pallet?

@lavrton
Copy link
Contributor Author

lavrton commented Jun 1, 2013

Do you know how to highlight ?

Not yet. Best way - like in sublimelint plugin. Command pallet - good too.

@lavrton
Copy link
Contributor Author

lavrton commented Jun 4, 2013

I am creating this feature. Now works in this way: command - "CoffeeScript: Lint". Result:
Result Example

@aponxi
Copy link
Collaborator

aponxi commented Jun 4, 2013

sweet, I was going to get started on that too. Here paste this place holder on where coffeelint functions start in py. It helps locate things on the scrollbar.

#     e88~-_             88~\   88~\                     888     ,e,            d8  
#    d888   \  e88~-_  _888__ _888__  e88~~8e   e88~~8e  888      "  888-~88e _d88__
#    8888     d888   i  888    888   d888  88b d888  88b 888     888 888  888  888  
#    8888     8888   |  888    888   8888__888 8888__888 888     888 888  888  888  
#    Y888   / Y888   '  888    888   Y888    , Y888    , 888     888 888  888  888  
#     "88_-~   "88_-~   888    888    "88___/   "88___/  888____ 888 888  888  "88_/
# 
######################################################################################

@lavrton lavrton mentioned this issue Aug 24, 2013
6 tasks
@lavrton
Copy link
Contributor Author

lavrton commented Aug 24, 2013

3b506d9
Now you can lint current file via coffeelint. Coffee: Lint command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants