Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/TopologicalCharge #108

Merged
merged 7 commits into from Apr 5, 2023
Merged

Feat/TopologicalCharge #108

merged 7 commits into from Apr 5, 2023

Conversation

fjosw
Copy link
Contributor

@fjosw fjosw commented Mar 14, 2023

I started implementing a new module which can compute the topological charge using the Wilson flow. At the moment the module uses an adaptive integrator, Grid also has a standard integrator which could be used alternatively.

For now, the output is only printed to the log.

@aportelli
Copy link
Owner

Hi @fjosw thanks this is a great addition. Could you add something that output the result to disk please (it can be a single number HDF5)? My convention is to assume that the primary source of results are files on disk, not the log (although a number of modules show results of part of it in the log). Thanks

@fjosw
Copy link
Contributor Author

fjosw commented Mar 15, 2023

I thought a bit more about the output today and I could imagine outputting both, the energy density and the topological charge, as a function of the flow time instead of just outputting the charge at the final flow time. This would also facilitate the extraction of $t_0$ and $w_0$. If we go down that route a name like FlowObservables would maybe better describe the module.

@fjosw
Copy link
Contributor Author

fjosw commented Mar 30, 2023

I have put this PR on hold for now as Chris Kelly has made relevant changes to the Wilson Flow functionality on the dirichlet branch which Peter intends to merge soon (paboyle/Grid#412). An example of the new functionality can for example be found here.

@fjosw fjosw marked this pull request as ready for review April 4, 2023 16:35
@fjosw fjosw requested a review from aportelli as a code owner April 4, 2023 16:35
@fjosw
Copy link
Contributor Author

fjosw commented Apr 4, 2023

I adopted the model to the recent changes from the dirichlet branch, implemented the computation of the flow observables at each step of the Wilson flow smearing and added an hdf5 output to the module.

Copy link
Owner

@aportelli aportelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks ready to go. Please see one minor comment. Could you please confirm that you checked it does serialize to a 2D HDF5 array?

Hadrons/Modules/MGauge/FlowObservables.hpp Outdated Show resolved Hide resolved
@fjosw
Copy link
Contributor Author

fjosw commented Apr 5, 2023

I improved the header comment.

The output does not serialize to a 2D array but instead to four 1D arrays with separate descriptions. I followed up on Simon's suggestion and prioritized verbosity over memory efficiency. One would typically only compute the output once per configuration and the file size is about 20k for typical flow times so I think memory overhead is not a concern here.

@aportelli
Copy link
Owner

Good with me, thanks!

@aportelli aportelli merged commit 7943826 into aportelli:develop Apr 5, 2023
2 of 6 checks passed
@fjosw fjosw deleted the feat/qtop branch April 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants