New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/TopologicalCharge #108
Conversation
Hi @fjosw thanks this is a great addition. Could you add something that output the result to disk please (it can be a single number HDF5)? My convention is to assume that the primary source of results are files on disk, not the log (although a number of modules show results of part of it in the log). Thanks |
I thought a bit more about the output today and I could imagine outputting both, the energy density and the topological charge, as a function of the flow time instead of just outputting the charge at the final flow time. This would also facilitate the extraction of |
I have put this PR on hold for now as Chris Kelly has made relevant changes to the Wilson Flow functionality on the |
I adopted the model to the recent changes from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks ready to go. Please see one minor comment. Could you please confirm that you checked it does serialize to a 2D HDF5 array?
I improved the header comment. The output does not serialize to a 2D array but instead to four 1D arrays with separate descriptions. I followed up on Simon's suggestion and prioritized verbosity over memory efficiency. One would typically only compute the output once per configuration and the file size is about 20k for typical flow times so I think memory overhead is not a concern here. |
Good with me, thanks! |
I started implementing a new module which can compute the topological charge using the Wilson flow. At the moment the module uses an adaptive integrator, Grid also has a standard integrator which could be used alternatively.
For now, the output is only printed to the log.