Test/perambulator gpu #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed-up of the perambulator code, which is particularly drastic for setups with short solve times and many eigenvectors. The dominating cost in that case happens in ExtractSliceLocal (of the 3D eigenvectors) deeply nested inside the loops.
The solution of this pull request is to copy the data into an std::vector object before the actual code starts. At the expense of this extra memory this leads to a substantial speed-up (factor 5 for a particular setup that Fabian Joswig was testing).
The code is tested and compiles, runs, and produces bit-identical results with the old one on GPU and CPU. Fabian sees the factor 5 speed-up when running on Tursa.