Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/batch perambulator #88

Merged
merged 7 commits into from Jun 1, 2022

Conversation

felixerben
Copy link
Contributor

Two parts of this pull request:

  1. getReference -> getObjectDependencies: This fixes the currently broken distillation Noise code, which is not correctly handled by the scheduler
  2. re-organisation of the perambulator module to batch sources for batch deflation.

Code is tested to produce the same results (up to solver precision) on my laptop. It also compiles on Tursa. Nelson is testing the batch-deflation speed-up and correctness on Tursa currently.

@felixerben felixerben marked this pull request as draft May 25, 2022 11:04
@felixerben felixerben marked this pull request as ready for review June 1, 2022 15:42
@felixerben
Copy link
Contributor Author

With CG solver this produces bit identical perambulators. We also get good agreement using mixed precision solver on tursa and tesseract. ready to merge.

@aportelli aportelli merged commit a7fc26c into aportelli:develop Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants