Unable to reach the 404 page with this module in place

[jansensan]

For projects with this module, an actual 404 leads to the login page. The following projects are all using this module, and a URL which should show the 404 actually show the login page:

• https://sportlogiq.com/en/whatever
• https://www.vkitech.com/en/whatever
• https://arts-et-medias.net/en/whatever

Either there is a bug (maybe? not sure) or there is some additional documentation required to clarify how to ensure that an actual 404 presents the 404 template.

For pages that exist but require permissions, I agree this module does the proper job (redirecting to login), but when an actual 404 is needed, the user experience of a visitor being thrown to the login page rather than the 404 template is not useful.

Note that this issue replaces the one originally reported on apostrophe-workflow, as it is most likely this module (apostrophe-second-chance-login) that is the cause.

[boutell]

This module does work as designed in our experience — is there a particular configuration or combination of modules needed to trigger this "shows login button no matter what" behavior?

[jansensan]

The projects are also using apostrophe-workflow, could that affect the behaviour?

As a user (as opposed to anon), the 404 page is reachable, and it shows as unpublished (linked to the workflow?), but clicking on the big red button offers no option to publish a notFound template... (which sort of makes sense).

[boutell]

Honestly not sure. Does it occur in a simple boilerplate project? How about when you add workflow to that project?

…

On Thu, Apr 15, 2021 at 11:59 AM Mat Janson Blanchet < ***@***.***> wrote: The projects are also using apostrophe-workflow, could that affect the behaviour? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27L4C7YQASUNDSX2L33TI4EOTANCNFSM426CDFDA> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

[jansensan]

Will create this proto/boilerplate/test as soon as I can (likely mid next week) and will come back to you here

[jansensan]

@boutell So I created a project from the boilerplate, added workflow and second chance login, and indeed, an actual 404 does go to the login page.

URL: https://github.com/jansensan/apostrophecms-404-issue
TODO: create the admin user (as you would when running the boilerplate project)

These would be my behavioral expectations:

• If the page/piece exists and is not covered by the current permissions (e.g. anon), yes lead the user to the login page
• If the page/piece does not exist, the 404 page/template should be served to the user

[boutell]

OK, thanks for verifying that. It seems reasonable that this ticket stay here in second chance login rather than in workflow, but it's important for us to know it won't happen unless workflow is present.

…

On Tue, Apr 20, 2021 at 2:07 PM Mat Janson Blanchet < ***@***.***> wrote: @boutell <https://github.com/boutell> So I created a project from the boilerplate, added workflow and second chance login, and indeed, an actual 404 does go to the login page. URL: https://github.com/jansensan/apostrophecms-404-issue TODO: create the admin user (as you would when running the boilerplate project) These would be my behavioral expectations: - If the page/piece exists and is not covered by the current permissions (e.g. anon), yes lead the user to the login page - If the page/piece does not exist, the 404 page/template should be served to the user — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27NB6TLUUL2MTMELYQLTJW7HVANCNFSM426CDFDA> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his