Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare minimum requirements to paste table into rich text editor #3933

Closed
wants to merge 1 commit into from
Closed

Add bare minimum requirements to paste table into rich text editor #3933

wants to merge 1 commit into from

Conversation

jmiller-rise8
Copy link
Contributor

@jmiller-rise8 jmiller-rise8 commented Nov 4, 2022

Summary

Per conversations in Discord, I am submitting a PR with only the bare minimum components to use TipTap tables. More conversations are needed for a good UI/UX solution for adding a new table.

What are the specific steps to test this change?

  1. Run the website and log in as an admin
  2. Open a rich text editor
  3. Paste in a table and Update

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@boutell
Copy link
Member

boutell commented Nov 7, 2022

Thanks for this starting point @jmiller-rise8. You're right, this issue needs more attention from our team. We'll be putting in the needed design and implementation effort on our side soon.

@boutell
Copy link
Member

boutell commented Jan 31, 2023

Closing, with thanks, because we're shipping an implementation of tables this week that addresses the necessary UI (in a basic way for now).

@boutell boutell closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants