Feature/stepper #40
Merged
Feature/stepper #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: release 1.2.0
boutell
requested changes
Oct 24, 2023
index.js
Outdated
| @@ -2,6 +2,8 @@ const fs = require('fs'); | |||
| const path = require('path'); | |||
| const connectMultiparty = require('connect-multiparty'); | |||
| const fields = require('./lib/fields'); | |||
| const recaptcha = require('./lib/recaptcha'); | |||
| const process = require('./lib/process'); | |||
There was a problem hiding this comment.
I wouldn't call a variable process because code in the module might need to access the process global at some point.
| {% set prependIfPrefix = apos.modules['@apostrophecms/form'].prependIfPrefix %} | ||
|
|
||
| <div data-apos-form-groups class="apos-form-groups {{ prependIfPrefix('__groups') }}"> | ||
| {% for group in data.widget.groups %} |
There was a problem hiding this comment.
Nice. I guess from the POV of the code that handles form submissions it just hoovers up the nested fields like everything else?
boutell
requested changes
Oct 24, 2023
index.js
Outdated
| @@ -3,7 +3,7 @@ const path = require('path'); | |||
| const connectMultiparty = require('connect-multiparty'); | |||
| const fields = require('./lib/fields'); | |||
| const recaptcha = require('./lib/recaptcha'); | |||
| const process = require('./lib/process'); | |||
| const processor = require('./lib/process'); | |||
There was a problem hiding this comment.
Please rename the file too, just for consistency, sorry 🙏
boutell
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add group widget
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: