Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing select icon #42

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix missing select icon #42

merged 1 commit into from
Oct 27, 2023

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Oct 27, 2023

Summary

Add missing form select widget icon

What are the specific steps to test this change?

⚠️ the icons are displayed only in the editor modal

  1. Open the widget editor modal
  2. When you click on the Add Content button you must see an icon for the select widget

If you see the following it's a failure
widgets

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun requested a review from boutell October 27, 2023 14:31
@haroun haroun self-assigned this Oct 27, 2023
@haroun haroun merged commit 82fe878 into main Oct 27, 2023
6 checks passed
@haroun haroun deleted the feature/missing-icon branch October 27, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants