Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various bugs #6

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix various bugs #6

merged 3 commits into from
Aug 15, 2023

Conversation

ETLaurent
Copy link
Contributor

@ETLaurent ETLaurent commented Aug 14, 2023

Fixing 1 bug and 2 minor things.

see PR comments

@@ -46,7 +48,7 @@ module.exports = {
} else if (obj.type === 'area') {
return Object.keys(obj.options.widgets).flatMap(widget => {
const { schema = [] } = self.apos.modules[`${widget}-widget`];
return schema.map(searchRelationships);
return schema.flatMap(searchRelationships);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before after
image image

@@ -76,7 +76,6 @@ export default {
this.selectedFile = null;
},
cancel () {
this.modal.active = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was slowing the modal closing 🤷

font-weight: 600;
color: var(--a-base-3);
margin-top: 20px;
}

.apos-export__settings-row {
font-size: var(--a-type-large);
font-size: var(--a-type-base);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before after
image image

@ETLaurent ETLaurent requested a review from ValJed August 14, 2023 15:36
@ETLaurent ETLaurent merged commit 3daf033 into main Aug 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants