Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX refinements #8

Merged
merged 13 commits into from
Aug 29, 2023
Merged

UX refinements #8

merged 13 commits into from
Aug 29, 2023

Conversation

falkodev
Copy link
Contributor

@falkodev falkodev commented Aug 23, 2023

https://linear.app/apostrophecms/issue/PRO-4699/import-download-ux-refinements

Download flow

  • In piece manager, batch operation is title Export, should be Download <PIECE_TYPE>
  • In the Download modal, modal title is Export Article, should be Download Article
  • Download modal has no transition animations, should follow normal modal pattern
  • Change: Expand Download modal to 415px
  • Include related documents expansion → document types should be pre selected
  • Download modal: Export button should say Download and the button label should be pre-pended with the download icon
  • The gray separator at the bottom of modal that separates the Download & Cancel buttons from the modal options color should be var(--a-base-9)
  • Document Format’s select is not our standard Select input and has big padding, can this be a normal Select?
  • .apos-export__description give this a margin-top of 5px
  • Extra can we animate expand/contract the related doc types?
  • Change give .apos-modal__body a padding of 30px 20px

Import Flow

  • Import modal has no transition animations, should follow normal modal pattern
  • From piece manager context menu, the Import operation label should say Import <PIECE_TYPE>
  • Import button should say Import <PIECE_TYPE> and be prepended with the upload icon
  • Buttons at the bottom of the modal should be separated by a gray separator, same styles as Download modal
  • give .apos-modal__body a padding of 30px 20px

@linear
Copy link

linear bot commented Aug 23, 2023

PRO-4699 Import / Download UX refinements

Using https://import-export-docs.a3.apos.dev/ as a testing ground:

Download flow

  • In piece manager, batch operation is title Export, should be Download <PIECE_TYPE>

  • In the Download modal, modal title is Export Article, should be Download Article

  • Download modal has no transition animations, should follow normal modal pattern

  • Change: Expand Download modal to 415px

  • Include related documents expansion → document types should be pre selected

  • Download modal: Export button should say Download and the button label should be pre-pended with the download icon

    image.png

  • The gray separator at the bottom of modal that separates the Download & Cancel buttons from the modal options color should be var(--a-base-9)

  • Document Format’s select is not our standard Select input and has big padding, can this be a normal Select?

  • .apos-export__description give this a margin-top of 5px

  • Extra can we animate expand/contract the related doc types?

  • Change give .apos-modal__body a padding of 30px 20px

Import Flow

  • Import modal has no transition animations, should follow normal modal pattern

  • From piece manager context menu, the Import operation label should say Import <PIECE_TYPE>

  • Import button should say Import <PIECE_TYPE> and be prepended with the upload icon

    image.png

  • Buttons at the bottom of the modal should be separated by a gray separator, same styles as Download modal

  • give .apos-modal__body a padding of 30px 20px

cc etienne alex

@falkodev falkodev changed the title Fix modal transition UX refinements Aug 25, 2023
@falkodev falkodev marked this pull request as ready for review August 25, 2023 14:14
Copy link
Contributor

@ETLaurent ETLaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ETLaurent ETLaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

height should probably not be set on document.documentElement

Copy link
Contributor

@ETLaurent ETLaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in variable name

Copy link
Contributor

@ETLaurent ETLaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use a ref to get the container element

@falkodev falkodev merged commit e4f0157 into main Aug 29, 2023
9 checks passed
@falkodev falkodev deleted the pro-4699-ux-refinement branch August 29, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants