Remove dependency on postcss #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirly
reviewed
Nov 30, 2018
| }) | ||
|
|
||
| value = csstree.generate(ast).slice(name.length + 1); | ||
| value = value.slice(0, value.length - 1); |
There was a problem hiding this comment.
You may want to extract 302-317 to a function. Similar to filterCss except that it could not return the new value.
boutell
reviewed
Nov 30, 2018
|
From their readme:
npm reports 8 million downloads a month for this package and it is depended on by these packages (including SVGO and CSSO). |
|
I can write additional tests if you think that's required. |
|
This has been rolled back for now (1.19.3), pending further examination of #269, please take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postcssis a pretty heavy weight dependency if it is only being used for parsing an AST.Replaced with css-tree.