Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - comment out circleci #628

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

alfreema
Copy link
Contributor

@alfreema alfreema commented Jun 29, 2023

Comment out the circleci reference in the README.md. It's misleading to the community that something is untrustworthy or broken.

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Comment out the circleci reference in the README.md.   It's misleading to the community that something is untrustworthy or broken.
@BoDonkey BoDonkey self-requested a review June 29, 2023 13:01
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rip out circleci completely (remove that bit, and remove the .circle-something folder). Whatever we do in future, it won't be circleci.

Copy link
Contributor

@BoDonkey BoDonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@alfreema
Copy link
Contributor Author

alfreema commented Jun 29, 2023

Okidoke I removed the reference entirely from README.md (instead of commenting it out), and then removed the .circleci directory. I believe that last commit is reflected in this Pull Request now, but I have never modified a Pull Request after submitting it so let me know if I screwed it up. :)

@boutell boutell self-requested a review June 29, 2023 16:19
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First: thank you so much for contributing this! My apologies, I though the PR was from Bob because he had mentioned sending one. Not that I should be curt with Bob either 🤪

And second: looks great, merging!

@boutell boutell merged commit cb6efe1 into apostrophecms:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants