working and passing tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abea
reviewed
Jul 9, 2020
index.js
Outdated
| reject | ||
| }); | ||
| if (!working) { | ||
| one(); |
There was a problem hiding this comment.
Coding top down like this it would be helpful to have a more descriptive name on this one.
index.js
Outdated
| } | ||
| function createWorker() { | ||
| const worker = cp.fork(`${__dirname}/worker.js`, { | ||
| stdio: 'inherit' // TODO back to ignore |
There was a problem hiding this comment.
What's the work to be done here?
abea
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @abea! I opened this PR on a new module properly! I'm so goddamn excited!
What do you think? The only thing I should have to tell you, if I wrote the README properly, is that this is a DGAD functional requirement; they need a forms widget that allows editors to supply their own (potentially slow) regular expressions for form validation.