Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formtastic_cell.rb #313

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Conversation

ryan2johnson9
Copy link
Contributor

needed for formtastic select drop downs to work

needed for formtastic select drop downs to work
@apotonick
Copy link
Member

Thanks, man, but this is the wrong project. You need to send this PR to formtastic because they do not correctly include all helpers - please fix it there, too!

apotonick added a commit that referenced this pull request Aug 6, 2015
@apotonick apotonick merged commit ff976b3 into trailblazer:master Aug 6, 2015
@ryan2johnson9
Copy link
Contributor Author

Not sure I know enough to raise a ticket there.
I think in this case they are making use of the Rails helpers from their helpers. Would the correct way for them be to include the Rails Helpers in their helpers where they are used? If so, would this result in Rails helpers being included twice in a standard project?

@apotonick
Copy link
Member

Exactly, they have to include the Rails helpers where they actually use them. They won't be included twice, Ruby takes care of that, so, go for it!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants