Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell::I18n #377

Closed
wants to merge 1 commit into from
Closed

Cell::I18n #377

wants to merge 1 commit into from

Conversation

Kledal
Copy link
Contributor

@Kledal Kledal commented Feb 13, 2016

This PR is ongoing and tries to complete the work started in #279
fixes #272

This scopes the translation key to the following:
Given a Cell called I18nConcept::Testing a call to t('.test') will produce the following key:
cells.i18n_concept.testing.test

@Kledal
Copy link
Contributor Author

Kledal commented Feb 13, 2016

@apotonick Please review whenever you have the time 😄

@apotonick
Copy link
Member

Does this PR need #279 ? Wondering because you're using super in def t, and I can't find out where #t comes from.

This should all go to cells-rails, I don't want any Rails-specific code in Cells anymore. Also, shouldn't we test that with normal cells and concept cells?

Thanks!!!

@Kledal
Copy link
Contributor Author

Kledal commented Feb 15, 2016

Could you point me to where cells-rails is located. I've tried to look for it at Trailblazer and in your gems. But I'm properly overlooking something.

@apotonick
Copy link
Member

Haha, it doesn't exist, yet, we have to create it!

@Kledal
Copy link
Contributor Author

Kledal commented Feb 17, 2016

Lets do it! I'm ready 😄

@apotonick
Copy link
Member

@scarfacedeb
Copy link

Any news on this one? ✌️

@apotonick
Copy link
Member

Yeah, this would go to cells-rails. 😬

@Kledal Kledal closed this Jul 30, 2016
@Kledal Kledal deleted the i18n branch July 30, 2016 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n lazy lookup
3 participants