Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :struct options for properties. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marshall-lee
Copy link

Hello, @apotonick! I really appreciate stuff you build (Reform, Roar, etc), it's really game-changing!

I read a post about Reform 2.0 where you mentioned :struct option for properties which I found very useful in my tasks. However, I haven't found it implemented nor in Reform neither in Disposable. This patch fills this gap!

@marshall-lee
Copy link
Author

The problem here is that Disposable::Twin::Struct adds :sync method assuming that class already got Sync feature. Maybe I should propose this change to Reform::Form that has Sync already?

@apotonick
Copy link
Owner

Thanks! 😁

The Sync part is not a big problem, and this should go into Disposable as Reform is form-only.

We should also add a test that tests the struct: true. I still want to keep the old tests, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants