Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Since version 1.4.7, the "make a copy today"-button is missing #42

Closed
dasnessie opened this issue Oct 12, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@dasnessie
Copy link

dasnessie commented Oct 12, 2021

Description of the bug
Since upgrading to version 1.4.7, the "make a copy today"-button (and the delete button) in the top right corner of the edit view are missing. It's easier to access than the menu entry (long vs short press), so I don't think it should be removed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new entry
  2. Click on it
  3. See no buttons in the top right corner

Expected behavior
I expect to see two buttons in the top right corner, one for "make a copy today", and one for "delete".

Screenshots

System information (please complete the following information):

  • Device: Samsung Galaxy A5 (SM-A520F)
  • Android version: 9
  • OS: LineageOS 16.0
  • App version 1.4.7

Additional context
Feel free to ask for any other info you might need!

@dasnessie dasnessie added the bug Something isn't working label Oct 12, 2021
@apozas
Copy link
Owner

apozas commented Oct 13, 2021

Thank you very much for noticing this. The removal was not intended, so I will fix it and release a new version soon (all things going well, before the end of the week).

@igor-cali
Copy link
Contributor

igor-cali commented Oct 15, 2021

I think this issue is originated with f6ef1db.
I did not notice there where these buttons on the edit screens.
@apozas let me know if I can help.

@apozas
Copy link
Owner

apozas commented Oct 16, 2021

I believe that may be the case, indeed. I remember myself thinking on how to avoid using so many "same" layouts a few months ago, and there must had been a reason why my previous me didn't do it straight away xD. This is nevertheless a good excuse for me to find a more elegant solution. I will work on it today, and if I don't find an easy way I will just revert the changes. Thanks for your offering!

@igor-cali
Copy link
Contributor

igor-cali commented Oct 16, 2021

You can play with the Visibility attribute from the activities to avoid multiple layouts.

@apozas apozas closed this as completed in 5f42ebc Oct 17, 2021
@apozas
Copy link
Owner

apozas commented Oct 17, 2021

Well, it seems like 5f42ebc should fix the issue (at least it does for me). In the end it is playing with Visibilityes, so it's a much more elegant solution than what I had before. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants