MGR-89 avoid NPE

appNG · Apr 3, 2020 · bb53bf1 · bb53bf1
1 parent e5cca4b
commit bb53bf1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/main/java/org/appng/application/manager/business/Properties.java b/src/main/java/org/appng/application/manager/business/Properties.java
@@ -160,18 +160,20 @@ public class PropertyWrapper extends PropertyImpl {
 		}
 
 		public String getDisplayValue() {
-			if(Property.Type.MULTILINE.equals(getType())) {
+			if (Property.Type.MULTILINE.equals(getType())) {
 				return getClob();
 			}
 			return getActualString();
 		}
 
 		@Override
 		public String getActualString() {
+			String stringValue = getString();
 			if (hidePassword && Property.Type.PASSWORD.equals(getType())) {
-				return getString().replaceAll("\\.", "*");
+				return stringValue.substring(0, 2) + StringUtils.repeat('*', stringValue.length() - 4)
+						+ stringValue.substring(stringValue.length() - 2);
 			}
-			return getString();
+			return stringValue;
 		}
 
 		@Override

diff --git a/src/main/java/org/appng/application/manager/form/PropertyForm.java b/src/main/java/org/appng/application/manager/form/PropertyForm.java
@@ -75,8 +75,8 @@ public void validate(Site site, Application application, Environment environment
 		}
 		if (Property.Type.BOOLEAN.equals(getProperty().getType())) {
 			String stringValue = getProperty().getString();
-			boolean value = stringValue.equalsIgnoreCase("on") || stringValue.equalsIgnoreCase("true");
-			getProperty().setValue(value);
+			boolean selected = StringUtils.equalsAnyIgnoreCase(stringValue, "on", "true");
+			getProperty().setValue(selected);
 		}
 	}