Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailinator yopmail as providers #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mdegoys
Copy link

@mdegoys mdegoys commented Nov 29, 2019

Add mailinator and yopmail addresses in providers list.

Related to: https://appaloosa.slack.com/archives/C029CR8DN/p1574936598003400

@ammelanie
Copy link

ammelanie commented Dec 13, 2019

Do we want to update the gem version?

@mdegoys
Copy link
Author

mdegoys commented Dec 18, 2019

Do we want to update the gem version?

Yes that could be good, but actually I checked the original repo, and they already added a (very long) list of disposable domains which include mailinator and yopmail's domains: https://github.com/elcurator/providly/blob/master/lib/providly/disposable_domains.txt
Shouldn't we merge their changes into our fork ?

@ammelanie
Copy link

Hum, yep. I think that if we want to do that, we need to review all the differences to be sure that we really want all of them, what do you think?
Also, do we know why we forked the repo? Maybe, for adding a particular domain?

@mdegoys
Copy link
Author

mdegoys commented Dec 20, 2019

Hum, yep. I think that if we want to do that, we need to review all the differences to be sure that we really want all of them, what do you think?
Also, do we know why we forked the repo? Maybe, for adding a particular domain?

I'm not sure why we forked the repo, but there aren't many additional commits(5) from ARD (Arnaud Doucerain) that don't seem to do much more than adding the disposable domains, updating a gem and adding him as one of the authors. The El Curator project has closed so maybe we can just ask ARD directly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants