Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#37 feat: support string userId #38

Merged
merged 2 commits into from
Jul 15, 2021
Merged

#37 feat: support string userId #38

merged 2 commits into from
Jul 15, 2021

Conversation

gotokatsuya
Copy link
Contributor

#37

@ZigZagT
Copy link
Contributor

ZigZagT commented Jul 15, 2021

@gotokatsuya thanks for your time putting the PR together!

Also for anyone else looking at this PR:
we're using type Union[str, int] for the userId in py-ab-testing package. Therefore we didn't need to update types there.

@ZigZagT ZigZagT merged commit 026ebcc into appannie:master Jul 15, 2021
@gotokatsuya
Copy link
Contributor Author

@ZigZagT Thanks you so much 😃

@gotokatsuya gotokatsuya deleted the patch/userid-string-type branch July 15, 2021 04:57
@SBoudrias
Copy link
Contributor

Awesome! Thanks for sending the PR and adding UTs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZigZagT ZigZagT ZigZagT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gotokatsuya @ZigZagT @SBoudrias