fix publish workflow #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actions now has builtin auth support via the
GITHUB_TOKENvariable (doc).We used to use our own PAT for pushing the release info. Apparently, the PAT approach has stopped working just now. It's time to adopt the new workflow.
Besides using
GITHUB_TOKEN, I also simplified the workflow a little bit. In the old version, we were passing${{ github.event.release.target_commitish }}to the checkout action to allow publishing an arbitrary commit. It turns out we didn't need this feature at all. Therefore I'm removing it for simplicity.sample workflow output can be found here https://github.com/ZigZagT/ab-testing/runs/3073667970?check_suite_focus=true
(note NPM step is expected to fail with 401 as its a forked repo)