Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ST generic type #10

Merged
merged 2 commits into from
Nov 23, 2018
Merged

Remove ST generic type #10

merged 2 commits into from
Nov 23, 2018

Conversation

wxu-aa
Copy link
Contributor

@wxu-aa wxu-aa commented Nov 23, 2018

Removed ST type. The ST caused the flow checking broken.

Now it won't support Static Props, but works well for props check.

If we need use static props in our code, could only use $FlowFixMe for now.

Copy link

@kaix1n kaix1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SBoudrias
Copy link
Contributor

FYI, we shouldn't bump version in PR as this will make it harder to release. Bump versions with npm version before npm publish (and then git push --follow-tags).

@SBoudrias SBoudrias merged commit 7ffeb05 into appannie:master Nov 23, 2018
@SBoudrias SBoudrias deleted the Remove-ST-Type branch November 23, 2018 03:06
@xunuoi
Copy link
Contributor

xunuoi commented Nov 23, 2018

@SBoudrias Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants