Update types to use React.AbstractComponent #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restore the Then it could check the flow type for static props |
|
Done, I had to re-adjust the type to make this case pass properly. |
xunuoi
approved these changes
Dec 25, 2018
|
Actually had to remove the static types/WrappedComponent, it unfortunately didn't work in many cases :( |
|
@SBoudrias You mean even the latest Flow doesn't support static props of HOC well? 😰 |
|
At least now it does type validation; as previously it'd silently |
|
@SBoudrias You mean the
|
SBoudrias
added a commit
that referenced
this pull request
Dec 26, 2018
This PR is trying to reach a middle step between current status and the status of #16 By removing the second generic type, we actually add extra coverage around the locations where the context cause flow to silently set the type to `any`. (this catched 15 errors on our main repo) And it'll allow us to easily fill in the generic type manually in order to be 100% sure the types aren't `any`. This will make it easily usable with both flow 0.84 and and 0.89. ```js export default translate<typeof Comp>(Comp); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to 0.89 with the new HOC helper.