Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinda strange to put the run commands as overrides in fuge-config.js #20

Closed
rjrodger opened this issue Feb 2, 2016 · 9 comments
Closed

Comments

@rjrodger
Copy link

rjrodger commented Feb 2, 2016

would prefer to put them into the system yml file

@pelger
Copy link
Contributor

pelger commented Feb 2, 2016

Chose not to do this in order to keep the yml file compatible with docker-compose. May be worth revisiting this decision however.

@AdrianRossouw
Copy link
Contributor

but docker-compose.yml files also have an entry point ?

@pelger
Copy link
Contributor

pelger commented Feb 2, 2016

True enough in that a command entry is supported. @AdrianRossouw you want to take a look at this also ?

@rjrodger
Copy link
Author

rjrodger commented Feb 3, 2016

fuge should be bigger than docker :)
but in any case, wouldn't have a get-out-of-jail for meta data?

@mcollina
Copy link

mcollina commented Feb 3, 2016

I agree with you @rjrodger! I noted this to @pelger when he first demoed me fuge :D.
Given that the compose file is just yml, we can stick a fuge key for each microservice, and we jail there all our custom config.

@AdrianRossouw
Copy link
Contributor

I think we do get some benefit from building on the docker-compose.yml format, because they are far too big now to be able to change it significantly, but we should def. be able to extend it as needed.

Also, I personally don't like having .js and .yml config files mixed.

@rjrodger
Copy link
Author

rjrodger commented Feb 3, 2016

@AdrianRossouw +1 it is a bit jarring

@lucamaraschi
Copy link
Contributor

I like the idea of @mcollina as we could then strip-out the metadata informations of fuge returning a clean docker-compose file if needed.
Another alternative would be to create an overlay yml file which extends using the extends functionality of Docker compose to inject the metadata informations keeping fuge and the pure compose file separated but still outputting a valid docker-compose.yml file...I think more mechanical but with a clear separation of concerns.

@pelger
Copy link
Contributor

pelger commented Jul 26, 2017

Closing this issue as configuration has been rewritten!

@pelger pelger closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants