focusShortcuts, autofocus, addonBefore, addonAfter props added #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter, expandSuggestionsContainer- **focusShortcuts** [optional]
…/mohdashraf010897/Docs into feat/support-focusShortcuts-prop
mohdashraf010897
changed the title
…er) & expandSuggestionsContainer prop
bietkul
suggested changes
May 25, 2021
There was a problem hiding this comment.
@mohdashraf010897 Check the comments on react-searchbox and update docs everywhere. Did you add any new inner class in the lib?
bietkul
approved these changes
Jun 21, 2021
Since we are using hotkeys-js as direct dependency in our RS search components, we need not tell the user to install it manually
bietkul
approved these changes
Jun 23, 2021
This was referenced Jun 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description : focusShortcuts, autofocus, addonBefore, addonAfter, expandSuggestionsContainer props newly added to enhance the searchbox ui.
Notion Link
React Searchbox: Implementation PR Link
ReactiveSearch: Web & Vue: Implementation PR Link
Vue Searchbox: Implementation PR Link
Libraries Affected: