Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveMap component behavior #35

Closed
15 tasks done
siddharthlatest opened this issue Feb 7, 2017 · 2 comments
Closed
15 tasks done

ReactiveMap component behavior #35

siddharthlatest opened this issue Feb 7, 2017 · 2 comments
Assignees
Milestone

Comments

@siddharthlatest
Copy link
Member

siddharthlatest commented Feb 7, 2017

  • defaultZoom prop should be present and set to 13. Validation: accept values in range [0, 20].
  • defaultCenter prop should be added. It takes in a object with lat and lng key associated with valid float numbers { lat: 37.74, lng: -122.45 }. lng can be an integer or float between [-180,180] and lat can be an integer or float between [-90, 90].
  • Rename mapStyle to defaultMapStyle.
  • Changing size prop should re-render the map results. Also, validate size to be between [1, 1000].
  • Validate from prop to be >= 0.
  • Add a prop for autoCenter.
  • Rename defaultPin prop to defaultMarkerImage.
  • Rename streamPin prop to streamMarkerImage.
  • Rename rotateOnUpdate prop to autoMarkerPosition.
  • Rename clearOnEmpty to autoMapRender.
  • Rename markerCluster to setMarkerCluster.
  • Rename streamActiveTime to streamTTL. streamTTL prop should be a Number that's >= 0 and <= 1000 (counted in seconds).
  • Remove markerOnDelete prop.
  • showPopoverOn prop should accept "click" and "mouseover" as valid values, don't need the On prefix in the values.
  • For branding, always use the white bg logo irrespective of the theme and display it at the bottom right of the map, to the left of the navigation (+/-) buttons.
@siddharthlatest siddharthlatest added this to the v0.1.0 milestone Feb 7, 2017
@farhan687 farhan687 self-assigned this Feb 7, 2017
@siddharthlatest
Copy link
Member Author

siddharthlatest commented Feb 7, 2017

  • rename popoverContent to onPopoverTrigger function for specifying popover content.

@metagrover
Copy link
Contributor

Fixed here 93a8a23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants