Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] On <SelectedFilters>, showClearAll should always display the button #1155

Closed
kud opened this issue Sep 12, 2019 · 0 comments · Fixed by #1159
Closed

[Feature Request] On <SelectedFilters>, showClearAll should always display the button #1155

kud opened this issue Sep 12, 2019 · 0 comments · Fixed by #1159
Assignees

Comments

@kud
Copy link

kud commented Sep 12, 2019

Affected Projects
React

Is your feature request related to a problem? Please describe.
I would like to have a button which allows me to remove all filters. However I don't want the filters cloud with it. So, my solution was to do this:

<SelectedFilters showClearAll clearAllLabel="Remove all filters" />

and put showFilter={false} on each other component.

However, if you do that, you'll never get the clearAll button.

Describe the solution you'd like
showClearAll should display the clear all button anytime you've got a filter, even if showFilter is to false on it.

Describe alternatives you've considered
Make a special clearFilter component to define what you want to clear: a componentId or all filters like http://docs.searchkit.co/v2.0.0/components/navigation/reset.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants