Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): selectedFilters clearAll behavior #1159

Merged
merged 2 commits into from
Sep 17, 2019
Merged

fix(web): selectedFilters clearAll behavior #1159

merged 2 commits into from
Sep 17, 2019

Conversation

ShahAnuj2610
Copy link
Contributor

fixes #1155

jyash97
jyash97 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jyash97 jyash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@lakhansamani @bietkul any feedback or suggestion ?

@jyash97 jyash97 merged commit f1ccf95 into appbaseio:next Sep 17, 2019
@kud kud mentioned this pull request Sep 17, 2019
Closed
@ShahAnuj2610 ShahAnuj2610 deleted the issue/1155 branch September 17, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyash97 jyash97 jyash97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] On <SelectedFilters>, showClearAll should always display the button
2 participants
@ShahAnuj2610 @jyash97