Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors and improve stacktrace #163

Closed
1 task done
divyanshu013 opened this issue Jan 1, 2018 · 1 comment
Closed
1 task done

Handle errors and improve stacktrace #163

divyanshu013 opened this issue Jan 1, 2018 · 1 comment
Assignees
@divyanshu013
Labels
enhancement idea 🤔 Discuss new ideas or feature requests
Milestone
2.1.0

Comments

@divyanshu013
Copy link
Contributor

I'm submitting a ...

  • feature request

Expected / new behavior:

We should handle errors, for example by using componentDidCatch and improve the stacktrace for errors if we can, adding browser, OS and reactivesearch version info.
@divyanshu013 divyanshu013 added enhancement idea 🤔 Discuss new ideas or feature requests labels Jan 1, 2018
@divyanshu013 divyanshu013 added this to the 2.1.0 milestone Jan 1, 2018
@metagrover
Copy link
Contributor

Currently errors are emitted on the streams response, and https://github.com/appbaseio/reactivecore/blob/master/src/actions/index.js#L150-L153 handleError() is never getting called. Check appbase-js related methods for this.

@divyanshu013 divyanshu013 mentioned this issue Jan 10, 2018
Open
@dhruvdutt dhruvdutt mentioned this issue Apr 19, 2018
Merged
bietkul added a commit that referenced this issue Sep 17, 2021
@bietkul @siddharthlatest
feat: add rank feature property in RS API (#163)
1e2c0a6 
* feat: add rank feature property in RS API

* feat: update docs

* fix: add example for boost property

* Update reference.md

* Update reference.md

Co-authored-by: Siddharth Kothari <sids.aquarius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyanshu013 divyanshu013

Labels
enhancement idea 🤔 Discuss new ideas or feature requests
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@divyanshu013 @metagrover