Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unionise highlighting of results for fields with (native) subfields #357

Closed
metagrover opened this issue May 8, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@metagrover
Copy link
Contributor

Issue

Enhancement

Description

Currently, we only highlight results of dataFields which are being rendered in the view ignoring their sub-fields. For certain search use-cases where there won't be a full-word match, we only receive such highlights in the sub-fields (.search field w.r.t. appbaseio standard mappings). For example:



For results, where we don't have anything highlighted, we are receiving the marked highlights in .search subfield. So, it's best to unionise the highlight-results of dataFields with their respective sub-fields before rendering.

Reactivesearch version: 2.6.2

@siddharthlatest
Copy link
Member

One option here is to transparently pass the highlight key returned from the response in the onAllData and onData callbacks (will be renderAllData and renderData in v3.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants