Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pagination component clickable with JS disabled in browser #477

Closed
aol-nnov opened this issue Aug 14, 2018 · 2 comments
Closed

Make Pagination component clickable with JS disabled in browser #477

aol-nnov opened this issue Aug 14, 2018 · 2 comments
Labels
enhancement web 🕸️ Issues related to Web version of library

Comments

@aol-nnov
Copy link
Contributor

As a followup for #441 it is proposed to add href parameters to Button in Pagination component.

For example, ?SearchResult=1, ?SearchResult=2 and so on.

After this change, SSR enabled reactivesearch application will become fully crawlable by dummy crawlers (which do not execute js during crawling, but only follow urls)
@divyanshu013 divyanshu013 added enhancement web 🕸️ Issues related to Web version of library labels Aug 14, 2018
@aol-nnov aol-nnov mentioned this issue Sep 26, 2018
Closed
@aol-nnov
Copy link
Contributor Author

@metagrover please let me know, if it is the right way to add hrefs to Pagination Buttons or there is some better approach I'm not aware of.

metagrover added a commit that referenced this issue Sep 27, 2018
@metagrover
web: fix pagination href edge-case #477
0baa4cf
@metagrover
Copy link
Contributor

Released in v2.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement web 🕸️ Issues related to Web version of library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aol-nnov @divyanshu013 @metagrover