Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: DataSearch and CategorySearch is missing renderSuggestions on the interface #591

Closed
hbish opened this issue Oct 30, 2018 · 0 comments
Closed

Comments

@hbish
Copy link
Contributor

hbish commented Oct 30, 2018

Issue Type:
bug

Platform:
Web

Description:
As per the documentation on Custom Suggestions, renderSuggestion is exposed as a property on both DataSearch and CategorySearch.

This is currently not exposed through the interface

Minimal reproduction of the problem with instructions:
When trying to define renderSuggestions in DataSearch component in a react typescript app, the following error is observed.

/Users/benshi/prj/my-app/src/components/search/SearchHeader.tsx
(94,17): Property 'renderSuggestions' does not exist on type 'IntrinsicAttributes & DataSearchProps & { children?: ReactNode; }'.

Reactivesearch version:
2.12.1

Workaround
Currently it is possible to workaround by adding renderSuggestions: (...args: any[]) => any; to the d.ts file

metagrover pushed a commit that referenced this issue Oct 30, 2018
…591)

This PR is to resolve missing props on `DataSearch` and `CategorySearch` as documented in #591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants