Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): window undefined for DataSearch SSR #1351

Merged
merged 1 commit into from Feb 5, 2020
Merged

fix(web): window undefined for DataSearch SSR #1351

merged 1 commit into from Feb 5, 2020

Conversation

ShahAnuj2610
Copy link
Contributor

@ShahAnuj2610 ShahAnuj2610 commented Feb 3, 2020 •
edited

fixes #1338

@ShahAnuj2610 ShahAnuj2610 mentioned this pull request Feb 3, 2020
Closed
@ShahAnuj2610 ShahAnuj2610 changed the title fix(web): window undefined for DataSearch fix(web): window undefined for DataSearch SSR Feb 3, 2020
@jyash97 jyash97 merged commit 4c28822 into appbaseio:next Feb 5, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakhansamani lakhansamani lakhansamani approved these changes

@jyash97 jyash97 jyash97 approved these changes

@bietkul bietkul Awaiting requested review from bietkul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using DataSearch with showVoiceSearch on SSR failing window is not defined
3 participants
@ShahAnuj2610 @lakhansamani @jyash97