Prevent showLoadMore from causing setState error #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mimic the setValue signature by adding a `hasMounted = true` as a parameter at the end of updateQueryOptions - When checking `props.showLoadMore`, respond to whether or not the component has mounted by re-assigning state - Update the constructor to use the new parameter for updateQueryOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasMounted = trueas a parameter at the end of updateQueryOptionsprops.showLoadMore, respond to whether or not the component has mounted by re-assigning stateResult: using
showLoadMoreon MultiList should no longer throwsetStateerrors.This shouldn't have linting errors, as I have mimicked all of the code style to match the file, but I can't get the lint script to run without errors flooding my console that do not pertain to the code I have changed.