Feat/add reset default prop selected filters component #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bietkul
suggested changes
Jun 22, 2021
There was a problem hiding this comment.
@mohdashraf010897 There are some formatting changes. You can sync your branch with next branch and then fix the changes.
and tested list components
bietkul
suggested changes
Jun 28, 2021
bietkul
suggested changes
Jun 28, 2021
bietkul
suggested changes
Jun 28, 2021
| @@ -30,6 +31,7 @@ const SelectedFilters = { | |||
| selectedValues: this.selectedValues, | |||
| clearValues: this.clearValues, | |||
| setValue: this.setValue, | |||
| resetValuesToDefault: this.resetValuesToDefault, | |||
There was a problem hiding this comment.
@mohdashraf010897 You would have to update the documentation for it,
There was a problem hiding this comment.
This is how docs have it until now, would need writeup and content to add to the doc...
bietkul
approved these changes
Jun 29, 2021
bietkul
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added
resetToDefaultprop in SelectedFilters component, WhenresetToDefaultis set to true, then it would set the filter value to thedefaultValue.The default value for
resetToDefaultwould be false.Libraries Affected 👍
Feature Request PR
Notio Card
webDemo with resetToDefault prop
Demo w/o resetToDefault prop
MultiDropdownRangeDemo with resetToDefault propvueDemo with resetToDefault prop
Demo w/o resetToDefault prop
Range InputDemo with resetToDefault propLoom Demo:
LatestImplementationLoom Demo
Docs PR